domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Fix unclickable checkboxes (#30195)

Browse source 
Fix https://github.com/go-gitea/gitea/issues/30185, regression from
https://github.com/go-gitea/gitea/pull/30162.

The checkboxes were unclickable because the label was positioned over
the checkbox with `padding`. Now it uses `margin` so the checkbox itself
will be clickable in all cases.

Secondly, I changed the for/id linking to also add missing `for`
attributes when `id` is present. The other way around (only `for`
present) is currently not handled and I think there are likey no
occurences in the code and introducing new non-generated `id`s might
cause problems elsewhere if we do, so I skipped on that.

(cherry picked from commit 640850e15f56bbe01f5d8ea407f99c79dc38457e)
This commit is contained in:
silverwind 2024-03-31 01:00:58 +01:00 • committed by Gergely Nagy
parent 25303b2dfe
commit fbca0dd9a6
No known key found for this signature in database
2 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
web_src/css/modules/checkbox.css
View file

@ -41,7 +41,7 @@ input[type="radio"] {
.ui.checkbox label,
.ui.radio.checkbox label {
padding-left: 1.85714em;
margin-left: 1.85714em;
}
.ui.checkbox + label {