domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Move web JSON functions to web context and simplify code (#26132)

Browse source 
The JSONRedirect/JSONOK/JSONError functions were put into "Base" context
incorrectly, it would cause abuse.

Actually, they are for "web context" only, so, move them to the correct
place.

And by the way, use them to simplify old code: +75 -196
This commit is contained in:
wxiaoguang 2023-07-26 14:04:01 +08:00 • committed by GitHub
parent 338d03ce2f
commit dcd3a63128
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
36 changed files with 75 additions and 196 deletions
Download patch file Download diff file Expand all files Collapse all files

4
routers/web/admin/stacktrace.go
View file

@ -42,7 +42,5 @@ func Stacktrace(ctx *context.Context) {
func StacktraceCancel(ctx *context.Context) {
pid := ctx.Params("pid")
process.GetManager().Cancel(process.IDType(pid))
ctx.JSON(http.StatusOK, map[string]any{
"redirect": setting.AppSubURL + "/admin/monitor/stacktrace",
})
ctx.JSONRedirect(setting.AppSubURL + "/admin/monitor/stacktrace")
}