domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Use known issue IID to generate new PR index number when migrating from GitLab (#28616) (#28618)

Browse source 
Backport #28616 by wxiaoguang

Fix #13884

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit bf983735fd)
This commit is contained in:
Giteabot 2023-12-27 09:59:29 +08:00 • committed by Earl Warren
parent 120294c44e
commit da1b257733
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
2 changed files with 45 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
services/migrations/gitlab_test.go
View file

@ -514,3 +514,20 @@ func TestAwardsToReactions(t *testing.T) {
},
}, reactions)
}
func TestGitlabIIDResolver(t *testing.T) {
r := gitlabIIDResolver{}
r.recordIssueIID(1)
r.recordIssueIID(2)
r.recordIssueIID(3)
r.recordIssueIID(2)
assert.EqualValues(t, 4, r.generatePullRequestNumber(1))
assert.EqualValues(t, 13, r.generatePullRequestNumber(10))
assert.Panics(t, func() {
r := gitlabIIDResolver{}
r.recordIssueIID(1)
assert.EqualValues(t, 2, r.generatePullRequestNumber(1))
r.recordIssueIID(3) // the generation procedure has been started, it shouldn't accept any new issue IID, so it panics
})
}