domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Remove unnecessary variable assignments (#17695)

Browse source 
* Remove unnecessary variable assignments

As title

* enable ineffassign

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Gusted 2021-11-18 01:33:06 +00:00 • committed by GitHub
parent b01f6c1a8c
commit c98dd7a3e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
32 changed files with 59 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/web/middleware/binding.go
View file

@ -93,11 +93,9 @@ func Validate(errs binding.Errors, data map[string]interface{}, f Form, l transl
AssignForm(f, data)
typ := reflect.TypeOf(f)
val := reflect.ValueOf(f)
if typ.Kind() == reflect.Ptr {
typ = typ.Elem()
val = val.Elem()
}
if field, ok := typ.FieldByName(errs[0].FieldNames[0]); ok {