domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Don't fail silently if trying to add a collaborator twice (#4533)

Browse source 
* don't fail silently if trying to add a collaborator twice

* fix translation text

* added collaborator test

* improvee testcases

* Added tests to make sure a collaborator cannot be added twice
This commit is contained in:
Lanre Adelowo 2018-08-07 02:59:42 +01:00 • committed by Lunny Xiao
parent 7cb1c1cf20
commit c7a6ee5c0b
3 changed files with 109 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
routers/repo/setting.go
View file

@ -401,6 +401,12 @@ func CollaborationPost(ctx *context.Context) {
}
}
if got, err := ctx.Repo.Repository.IsCollaborator(u.ID); err == nil && got {
ctx.Flash.Error(ctx.Tr("repo.settings.add_collaborator_duplicate"))
ctx.Redirect(ctx.Repo.RepoLink + "/settings/collaboration")
return
}
if err = ctx.Repo.Repository.AddCollaborator(u); err != nil {
ctx.ServerError("AddCollaborator", err)
return