forked from forgejo/forgejo
Use CryptoRandomBytes
instead of CryptoRandomString
(#18439)
- Switch to use `CryptoRandomBytes` instead of `CryptoRandomString`, OAuth's secrets are copied pasted and don't need to avoid dubious characters etc. - `CryptoRandomBytes` gives  `CryptoRandomString` gives  possible states. - Add a prefix, such that code scanners can easily grep these in source code. - 32 Bytes + prefix
This commit is contained in:
parent
88939a5663
commit
aa23f477b7
4 changed files with 19 additions and 28 deletions
|
@ -43,7 +43,7 @@ func testAPICreateOAuth2Application(t *testing.T) {
|
|||
DecodeJSON(t, resp, &createdApp)
|
||||
|
||||
assert.EqualValues(t, appBody.Name, createdApp.Name)
|
||||
assert.Len(t, createdApp.ClientSecret, 44)
|
||||
assert.Len(t, createdApp.ClientSecret, 56)
|
||||
assert.Len(t, createdApp.ClientID, 36)
|
||||
assert.NotEmpty(t, createdApp.Created)
|
||||
assert.EqualValues(t, appBody.RedirectURIs[0], createdApp.RedirectURIs[0])
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue