domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Fix safari cookie session bug (#24772)

Browse source 
Partically backport #24330

Related: #24176

Maybe fix #24770

(cherry picked from commit 64cc691b7f)
This commit is contained in:
wxiaoguang 2023-05-18 09:10:23 +08:00 • committed by Earl Warren
parent b261f44478
commit 9bc4887cb7
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
2 changed files with 44 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

24
modules/context/context_test.go Normal file
View file

@ -0,0 +1,24 @@
// Copyright 2023 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package context
import (
"net/http"
"net/http/httptest"
"testing"
"code.gitea.io/gitea/modules/setting"
"github.com/stretchr/testify/assert"
)
func TestRemoveSessionCookieHeader(t *testing.T) {
w := httptest.NewRecorder()
w.Header().Add("Set-Cookie", (&http.Cookie{Name: setting.SessionConfig.CookieName, Value: "foo"}).String())
w.Header().Add("Set-Cookie", (&http.Cookie{Name: "other", Value: "bar"}).String())
assert.Len(t, w.Header().Values("Set-Cookie"), 2)
removeSessionCookieHeader(w)
assert.Len(t, w.Header().Values("Set-Cookie"), 1)
assert.Contains(t, "other=bar", w.Header().Get("Set-Cookie"))
}