domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Remove most path-based golangci exclusions (#24214)

Browse source 
They are non-obvious and do not survive refactor.

Will replace with `//nolint` comments after CI results are in.
This commit is contained in:
silverwind 2023-04-20 04:08:01 +02:00 • committed by GitHub
parent 594efb9b66
commit 938b591994
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 29 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/log/file.go
View file

@ -181,7 +181,7 @@ func (log *FileLogger) DoRotate() error {
}
if log.Compress {
go compressOldLogFile(fname, log.CompressionLevel)
go compressOldLogFile(fname, log.CompressionLevel) //nolint:errcheck
}
// re-start logger
@ -216,7 +216,7 @@ func compressOldLogFile(fname string, compressionLevel int) error {
if err != nil {
zw.Close()
fw.Close()
util.Remove(fname + ".gz")
util.Remove(fname + ".gz") //nolint:errcheck
return err
}
reader.Close()