domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Suggest to use Type=simple for systemd service (#28717)

Browse source 
Although the systemd notify support was added, it seems that there are
some problems (#28553, for the "non-installed" instance)
This commit is contained in:
wxiaoguang 2024-01-07 23:18:04 +08:00 • committed by GitHub
parent 9296c31ff7
commit 79da4bbc56
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
modules/graceful/manager_common.go
View file

@ -10,6 +10,9 @@ import (
"time"
)
// FIXME: it seems that there is a bug when using systemd Type=notify: the "Install Page" (INSTALL_LOCK=false) doesn't notify properly.
// At the moment, no idea whether it also affects Windows Service, or whether it's a regression bug. It needs to be investigated later.
type systemdNotifyMsg string
const (