domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Add io.Closer guidelines (#29387)

Browse source 
Co-authored-by: Yarden Shoham <git@yardenshoham.com>
(cherry picked from commit ad0a34b492c3d41952ff4648c8bfb7b54c376151)
This commit is contained in:
KN4CK3R 2024-02-25 14:05:23 +01:00 • committed by Earl Warren
parent 3723caf762
commit 753f9711e9
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
7 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/git/repo_base_gogit.go
View file

@ -88,16 +88,17 @@ func OpenRepository(ctx context.Context, repoPath string) (*Repository, error) {
}
// Close this repository, in particular close the underlying gogitStorage if this is not nil
func (repo *Repository) Close() (err error) {
func (repo *Repository) Close() error {
if repo == nil || repo.gogitStorage == nil {
return
return nil
}
if err := repo.gogitStorage.Close(); err != nil {
gitealog.Error("Error closing storage: %v", err)
}
repo.gogitStorage = nil
repo.LastCommitCache = nil
repo.tagCache = nil
return
return nil
}
// GoGitRepo gets the go-git repo representation