domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Delete issue_service.CreateComment (#26298)

Browse source 
I noticed that `issue_service.CreateComment` adds transaction operations
on `issues_model.CreateComment`, we can merge the two functions and we
can avoid calling each other's methods in the `services` layer.

Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
caicandong 2023-08-04 21:34:34 +08:00 • committed by GitHub
parent 2de0752be7
commit 6151e69d95
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 17 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

3
services/pull/comment.go
View file

@ -11,7 +11,6 @@ import (
user_model "code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/git"
"code.gitea.io/gitea/modules/json"
issue_service "code.gitea.io/gitea/services/issue"
)
// getCommitIDsFromRepo get commit IDs from repo in between oldCommitID and newCommitID
@ -90,7 +89,7 @@ func CreatePushPullComment(ctx context.Context, pusher *user_model.User, pr *iss
ops.Content = string(dataJSON)
comment, err = issue_service.CreateComment(ctx, ops)
comment, err = issues_model.CreateComment(ctx, ops)
return comment, err
}