domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393)

Browse source 
Since 2015/2016, there is a global pollution: ".ui.left" / ".ui.right".

Fomantic UI doesn't work this way, it just conflicts with many Fomantic
definitions.

This PR starts the cleaning work of such techinical debts.

And, the "label list" page has been quite messy for long time, for
example, why "li" appears in "div" ......

And fix #24296

<details>


![image](https://user-images.githubusercontent.com/2114189/235051281-54c5374c-b5fd-4b5f-9aa2-02d4bb2d9112.png)


![image](https://user-images.githubusercontent.com/2114189/235055703-2ba042e0-4db7-4e63-8646-02f390d496b5.png)


![image](https://user-images.githubusercontent.com/2114189/235056310-4f6ffdc2-5758-4927-8fb8-314d9fb72a6b.png)


![image](https://user-images.githubusercontent.com/2114189/235058400-dab1c9ec-3325-4671-8345-aee6b0b68042.png)


![image](https://user-images.githubusercontent.com/2114189/235058424-85509532-b9bc-43ad-b00f-a87184c60f22.png)

</details>
This commit is contained in:
wxiaoguang 2023-04-29 19:35:59 +08:00 • committed by GitHub
parent 72e956b79a
commit 5a5ab8ef5a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
19 changed files with 168 additions and 162 deletions
Download patch file Download diff file Expand all files Collapse all files

59
web_src/css/base.css
View file

@ -1472,10 +1472,12 @@ img.ui.avatar,
color: var(--color-gold) !important;
}
/* FIXME: this is a serious pollution, do not use this for "float: left" anymore */
.ui.left:not(.action) {
float: left;
}
/* FIXME: this is a serious pollution, do not use this for "float: right" anymore */
.ui.right:not(.action) {
float: right;
}
@ -2660,38 +2662,6 @@ table th[data-sortt-desc] .svg {
background: var(--color-secondary-dark-1) !important;
}
.labelspage {
list-style: none;
padding-top: 0;
}
.labelspage .item {
border-bottom: 1px solid var(--color-secondary);
border-top: none;
}
.labelspage .item a {
font-size: 12px;
padding-right: 10px;
color: var(--color-text-light);
}
.labelspage .item a:hover {
color: var(--color-primary-light-2);
}
.labelspage .item a.open-issues {
margin-right: 30px;
}
.labelspage .item:last-child {
border-bottom: none;
padding-bottom: 0;
}
.labelspage .orglabel {
opacity: 0.7;
}
/* https://github.com/go-gitea/gitea/pull/11486 */
.ui.sub.header {
@ -2796,21 +2766,16 @@ table th[data-sortt-desc] .svg {
height: 15px;
}
@media (max-width: 767px) {
.ui.stackable.menu:not(.no-vertical-tabs) {
overflow-y: hidden;
overflow-x: auto;
flex-direction: row;
flex-wrap: nowrap !important;
}
.ui.stackable.menu:not(.no-vertical-tabs) .item {
width: initial !important;
}
.ui.stackable.menu:not(.no-vertical-tabs) > .dropdown.item {
position: initial;
}
.ui.stackable.menu:not(.no-vertical-tabs) .menu {
flex-direction: row;
.g-menu-stackable-scrollable {
overflow-y: hidden;
overflow-x: auto;
}
@media (max-width: 767.98px) {
/* also respect Fomantic's "stackable" definition, use the same breakpoint to reset our styles */
.g-menu-stackable-scrollable {
overflow-x: unset;
overflow-y: unset;
}
}