domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Delete a user's public key via admin api (closes #3014) (#3059)

Browse source 
* Delete a user's public key via admin api

* Test admin ssh endpoint for creating a new ssh key

* Adapt public ssh key test to also test the delete operation

* Test that deleting a missing key will result in a 404

* Test that a normal user can't delete another user's ssh key

* Make DeletePublicKey return err

* Update swagger doc
This commit is contained in:
Vlad Temian 2017-12-06 12:27:10 +02:00 • committed by Lauris BH
parent c7fb6e3087
commit 469ab99e9a
6 changed files with 324 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
models/ssh_key.go
View file

@ -506,10 +506,7 @@ func deletePublicKeys(e *xorm.Session, keyIDs ...int64) error {
func DeletePublicKey(doer *User, id int64) (err error) {
key, err := GetPublicKeyByID(id)
if err != nil {
if IsErrKeyNotExist(err) {
return nil
}
return fmt.Errorf("GetPublicKeyByID: %v", err)
return err
}
// Check if user has access to delete this key.