forked from forgejo/forgejo
Allow enable LDAP source and disable user sync via CLI (#20206)
The current `admin auth` CLI for managing authentication source of type LDAP via BindDN and Simple LDAP does not allow enabling the respective source, once disabled via `--not-active`. The same applies to `--synchronize-users` specifially for LDAP via BindDN. These changes add two new flags to LDAP related CLI commands: - `--active` for both LDAP authentication source types - `--disable-synchronize-users` for LDAP via BindDN Signed-off-by: justusbunsi <61625851+justusbunsi@users.noreply.github.com>
This commit is contained in:
parent
f9b172db65
commit
33f6f91008
2 changed files with 71 additions and 0 deletions
|
@ -858,6 +858,36 @@ func TestUpdateLdapBindDn(t *testing.T) {
|
|||
},
|
||||
errMsg: "Invalid authentication type. expected: LDAP (via BindDN), actual: OAuth2",
|
||||
},
|
||||
// case 24
|
||||
{
|
||||
args: []string{
|
||||
"ldap-test",
|
||||
"--id", "24",
|
||||
"--name", "ldap (via Bind DN) flip 'active' and 'user sync' attributes",
|
||||
"--active",
|
||||
"--disable-synchronize-users",
|
||||
},
|
||||
id: 24,
|
||||
existingAuthSource: &auth.Source{
|
||||
Type: auth.LDAP,
|
||||
IsActive: false,
|
||||
IsSyncEnabled: true,
|
||||
Cfg: &ldap.Source{
|
||||
Name: "ldap (via Bind DN) flip 'active' and 'user sync' attributes",
|
||||
Enabled: true,
|
||||
},
|
||||
},
|
||||
authSource: &auth.Source{
|
||||
Type: auth.LDAP,
|
||||
Name: "ldap (via Bind DN) flip 'active' and 'user sync' attributes",
|
||||
IsActive: true,
|
||||
IsSyncEnabled: false,
|
||||
Cfg: &ldap.Source{
|
||||
Name: "ldap (via Bind DN) flip 'active' and 'user sync' attributes",
|
||||
Enabled: true,
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for n, c := range cases {
|
||||
|
@ -1221,6 +1251,33 @@ func TestUpdateLdapSimpleAuth(t *testing.T) {
|
|||
},
|
||||
errMsg: "Invalid authentication type. expected: LDAP (simple auth), actual: PAM",
|
||||
},
|
||||
// case 20
|
||||
{
|
||||
args: []string{
|
||||
"ldap-test",
|
||||
"--id", "20",
|
||||
"--name", "ldap (simple auth) flip 'active' attribute",
|
||||
"--active",
|
||||
},
|
||||
id: 20,
|
||||
existingAuthSource: &auth.Source{
|
||||
Type: auth.DLDAP,
|
||||
IsActive: false,
|
||||
Cfg: &ldap.Source{
|
||||
Name: "ldap (simple auth) flip 'active' attribute",
|
||||
Enabled: true,
|
||||
},
|
||||
},
|
||||
authSource: &auth.Source{
|
||||
Type: auth.DLDAP,
|
||||
Name: "ldap (simple auth) flip 'active' attribute",
|
||||
IsActive: true,
|
||||
Cfg: &ldap.Source{
|
||||
Name: "ldap (simple auth) flip 'active' attribute",
|
||||
Enabled: true,
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for n, c := range cases {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue