Vendor Update Go Libs (#13444)

* denisenkom/go-mssqldb untagged -> v0.9.0

* github.com/editorconfig/editorconfig-core-go v2.3.7 -> v2.3.8

* github.com/go-testfixtures/testfixtures v3.4.0 -> v3.4.1

* github.com/mholt/archiver v3.3.2 -> v3.5.0

* github.com/olivere/elastic v7.0.20 -> v7.0.21

* github.com/urfave/cli v1.22.4 -> v1.22.5

* github.com/xanzy/go-gitlab v0.38.1 -> v0.39.0

* github.com/yuin/goldmark-meta untagged -> v1.0.0

* github.com/ethantkoenig/rupture 0a76f03a811a -> c3b3b810dc77

* github.com/jaytaylor/html2text 8fb95d837f7d -> 3577fbdbcff7

* github.com/kballard/go-shellquote cd60e84ee657 -> 95032a82bc51

* github.com/msteinert/pam 02ccfbfaf0cc -> 913b8f8cdf8b

* github.com/unknwon/paginater 7748a72e0141 -> 042474bd0eae

* CI.restart()

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

vendor/github.com/denisenkom/go-mssqldb/appveyor.yml

@@ -1,6 +1,7 @@
 version: 1.0.{build}
 
-os: Windows Server 2012 R2
+image:
+  - Visual Studio 2015
 
 clone_folder: c:\gopath\src\github.com\denisenkom\go-mssqldb
 
@@ -9,21 +10,36 @@ environment:
   HOST: localhost
   SQLUSER: sa
   SQLPASSWORD: Password12!
-  DATABASE: test  
-  GOVERSION: 111
+  DATABASE: test
+  GOVERSION: 113
   matrix:
     - GOVERSION: 18
-      SQLINSTANCE: SQL2016
+      SQLINSTANCE: SQL2017
     - GOVERSION: 19
-      SQLINSTANCE: SQL2016
+      SQLINSTANCE: SQL2017
     - GOVERSION: 110
-      SQLINSTANCE: SQL2016
+      SQLINSTANCE: SQL2017
     - GOVERSION: 111
-      SQLINSTANCE: SQL2016
+      SQLINSTANCE: SQL2017
+    - GOVERSION: 112
+      SQLINSTANCE: SQL2017
+    - SQLINSTANCE: SQL2017
+    - SQLINSTANCE: SQL2016
     - SQLINSTANCE: SQL2014
     - SQLINSTANCE: SQL2012SP1
     - SQLINSTANCE: SQL2008R2SP2
- 
+
+    #  Go 1.14+ and SQL2019 are available on the Visual Studio 2019 image only
+    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+      GOVERSION: 114
+      SQLINSTANCE: SQL2019
+    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+      GOVERSION: 115
+      SQLINSTANCE: SQL2019
+    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+      GOVERSION: 115
+      SQLINSTANCE: SQL2017
+
 install:
   - set GOROOT=c:\go%GOVERSION%
   - set PATH=%GOPATH%\bin;%GOROOT%\bin;%PATH%
@@ -35,15 +51,14 @@ build_script:
   - go build
 
 before_test:
-  # setup SQL Server 
-  - ps: | 
+  # setup SQL Server
+  - ps: |
       $instanceName = $env:SQLINSTANCE
       Start-Service "MSSQL`$$instanceName"
       Start-Service "SQLBrowser"
   - sqlcmd -S "(local)\%SQLINSTANCE%" -Q "Use [master]; CREATE DATABASE test;"
   - sqlcmd -S "(local)\%SQLINSTANCE%" -h -1 -Q "set nocount on; Select @@version"
   - pip install codecov
- 
 
 test_script:
   - go test -race -cpu 4 -coverprofile=coverage.txt -covermode=atomic

vendor/github.com/denisenkom/go-mssqldb/mssql.go

@@ -285,7 +285,7 @@ func (c *Conn) begin(ctx context.Context, tdsIsolation isoLevel) (tx driver.Tx,
 	}
 	tx, err = c.processBeginResponse(ctx)
 	if err != nil {
-		return nil, c.checkBadConn(err)
+		return nil, err
 	}
 	return
 }

vendor/github.com/denisenkom/go-mssqldb/tds.go

@@ -838,6 +838,12 @@ func connect(ctx context.Context, c *Connector, log optionalLogger, p connectPar
 		defer cancel()
 	}
 	// if instance is specified use instance resolution service
+	if p.instance != "" && p.port != 0 {
+		// both instance name and port specified
+		// when port is specified instance name is not used
+		// you should not provide instance name when you provide port
+		log.Println("WARN: You specified both instance name and port in the connection string, port will be used and instance name will be ignored");
+	}
 	if p.instance != "" && p.port == 0 {
 		p.instance = strings.ToUpper(p.instance)
 		d := c.getDialer(&p)

vendor/github.com/denisenkom/go-mssqldb/token.go

@@ -704,14 +704,18 @@ func (ts *parseResp) sendAttention(ch chan tokenStruct) parseRespIter {
 }
 
 func (ts *parseResp) dlog(msg string) {
-	if ts.sess.logFlags&logDebug != 0 {
+	// logging from goroutine is disabled to prevent
+	// data race detection from firing
+	// The race is probably happening when
+	// test logger changes between tests.
+	/*if ts.sess.logFlags&logDebug != 0 {
 		ts.sess.log.Println(msg)
-	}
+	}*/
 }
 func (ts *parseResp) dlogf(f string, v ...interface{}) {
-	if ts.sess.logFlags&logDebug != 0 {
+	/*if ts.sess.logFlags&logDebug != 0 {
 		ts.sess.log.Printf(f, v...)
-	}
+	}*/
 }
 
 func (ts *parseResp) iter(ctx context.Context, ch chan tokenStruct, tokChan chan tokenStruct) parseRespIter {