domi/forgejo-domi
1
0
Fork 0
forked from forgejo/forgejo
Code Pull requests Activity

Don't warn users about *every* dirty form (#3707)

Browse source 
The choice regarding which forms should or should not trigger a warning
is subjective. I tried to be consistent and not warn about forms that:
 - run an action, rather than edit data: search, send an email.
 - delete data: a warning about losing data would be confusing

Note that forms on sign-in pages were already ignored (using a selector,
rather than an explicit class on the form element).

Fixes #3698.
This commit is contained in:
Gerben 2018-03-23 15:10:42 +01:00 • committed by Lunny Xiao
parent e64aa18dc9
commit 2dc6f15eca
15 changed files with 19 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

7
public/js/index.js
View file

@ -1663,8 +1663,11 @@ function selectRange($list, $select, $from) {
}
$(function () {
if ($('.user.signin').length > 0) return;
$('form').areYouSure();
// Warn users that try to leave a page after entering data into a form.
// Except on sign-in pages, and for forms marked as 'ignore-dirty'.
if ($('.user.signin').length === 0) {
$('form:not(.ignore-dirty)').areYouSure();
}
// Parse SSH Key
$("#ssh-key-content").on('change paste keyup',function(){