Upgrade bleve from v2.0.6 to v2.3.0 (#18132)

vendor/github.com/RoaringBitmap/roaring/arraycontainer.go

@@ -403,7 +403,7 @@ func (ac *arrayContainer) iorRun16(rc *runContainer16) container {
 		var result container
 		result = ac
 		for _, run := range rc.iv {
-			result = result.iaddRange(int(run.start), int(run.start)+int(run.length))
+			result = result.iaddRange(int(run.start), int(run.start)+int(run.length)+1)
 		}
 		return result
 	}

vendor/github.com/RoaringBitmap/roaring/fastaggregation.go

@@ -33,15 +33,6 @@ main:
 				s2 = x2.highlowcontainer.getKeyAtIndex(pos2)
 			} else {
 				c1 := x1.highlowcontainer.getContainerAtIndex(pos1)
-				switch t := c1.(type) {
-				case *arrayContainer:
-					c1 = t.toBitmapContainer()
-				case *runContainer16:
-					if !t.isFull() {
-						c1 = t.toBitmapContainer()
-					}
-				}
-
 				answer.highlowcontainer.appendContainer(s1, c1.lazyOR(x2.highlowcontainer.getContainerAtIndex(pos2)), false)
 				pos1++
 				pos2++
@@ -89,18 +80,7 @@ main:
 				}
 				s2 = x2.highlowcontainer.getKeyAtIndex(pos2)
 			} else {
-				c1 := x1.highlowcontainer.getContainerAtIndex(pos1)
-				switch t := c1.(type) {
-				case *arrayContainer:
-					c1 = t.toBitmapContainer()
-				case *runContainer16:
-					if !t.isFull() {
-						c1 = t.toBitmapContainer()
-					}
-				case *bitmapContainer:
-					c1 = x1.highlowcontainer.getWritableContainerAtIndex(pos1)
-				}
-
+				c1 := x1.highlowcontainer.getWritableContainerAtIndex(pos1)
 				x1.highlowcontainer.containers[pos1] = c1.lazyIOR(x2.highlowcontainer.getContainerAtIndex(pos2))
 				x1.highlowcontainer.needCopyOnWrite[pos1] = false
 				pos1++

vendor/github.com/RoaringBitmap/roaring/go.mod

@@ -3,8 +3,6 @@ module github.com/RoaringBitmap/roaring
 go 1.14
 
 require (
-	github.com/RoaringBitmap/gocroaring v0.4.0
-	github.com/RoaringBitmap/real-roaring-datasets v0.0.0-20190726190000-eb7c87156f76 // indirect
 	github.com/bits-and-blooms/bitset v1.2.0
 	github.com/mschoch/smat v0.2.0
 	github.com/stretchr/testify v1.4.0

vendor/github.com/RoaringBitmap/roaring/go.sum

@@ -1,7 +1,3 @@
-github.com/RoaringBitmap/gocroaring v0.4.0 h1:5nufXUgWpBEUNEJXw7926YAA58ZAQRpWPrQV1xCoSjc=
-github.com/RoaringBitmap/gocroaring v0.4.0/go.mod h1:NieMwz7ZqwU2DD73/vvYwv7r4eWBKuPVSXZIpsaMwCI=
-github.com/RoaringBitmap/real-roaring-datasets v0.0.0-20190726190000-eb7c87156f76 h1:ZYlhPbqQFU+AHfgtCdHGDTtRW1a8geZyiE8c6Q+Sl1s=
-github.com/RoaringBitmap/real-roaring-datasets v0.0.0-20190726190000-eb7c87156f76/go.mod h1:oM0MHmQ3nDsq609SS36p+oYbRi16+oVvU2Bw4Ipv0SE=
 github.com/bits-and-blooms/bitset v1.2.0 h1:Kn4yilvwNtMACtf1eYDlG8H77R07mZSPbMjLyS07ChA=
 github.com/bits-and-blooms/bitset v1.2.0/go.mod h1:gIdJ4wp64HaoK2YrL1Q5/N7Y16edYb8uY+O0FJTyyDA=
 github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=

vendor/github.com/RoaringBitmap/roaring/roaring.go

@@ -1552,3 +1552,27 @@ func (rb *Bitmap) Stats() Statistics {
 	}
 	return stats
 }
+
+func (rb *Bitmap) checkValidity() bool {
+	for _, c := range rb.highlowcontainer.containers {
+
+		switch c.(type) {
+		case *arrayContainer:
+			if c.getCardinality() > arrayDefaultMaxSize {
+				fmt.Println("Array containers are limited to size ", arrayDefaultMaxSize)
+				return false
+			}
+		case *bitmapContainer:
+			if c.getCardinality() <= arrayDefaultMaxSize {
+				fmt.Println("Bitmaps would be more concise as an array!")
+				return false
+			}
+		case *runContainer16:
+			if c.getSizeInBytes() > minOfInt(bitmapContainerSizeInBytes(), arrayContainerSizeInBytes(c.getCardinality())) {
+				fmt.Println("Inefficient run container!")
+				return false
+			}
+		}
+	}
+	return true
+}

vendor/github.com/RoaringBitmap/roaring/serialization_littleendian.go

@@ -297,8 +297,9 @@ func (ra *roaringArray) frozenView(buf []byte) error {
 			iBitset++
 		case 2:
 			containers[i] = &arrays[iArray]
-			arrays[iArray].content = arraysArena[:counts[i]+1]
-			arraysArena = arraysArena[counts[i]+1:]
+			sz := int(counts[i])+1
+			arrays[iArray].content = arraysArena[:sz]
+			arraysArena = arraysArena[sz:]
 			iArray++
 		case 3:
 			containers[i] = &runs[iRun]
@@ -401,7 +402,7 @@ func (bm *Bitmap) FreezeTo(buf []byte) (int, error) {
 			copy(arraysArena, v.content)
 			arraysArena = arraysArena[len(v.content):]
 			elems := len(v.content)
-			counts[i] = uint16(elems)-1
+			counts[i] = uint16(elems-1)
 			types[i] = 2
 		case *runContainer16:
 			copy(runsArena, v.iv)