forked from forgejo/forgejo
Enable more revive
linter rules (#30608)
Noteable additions: - `redefines-builtin-id` forbid variable names that shadow go builtins - `empty-lines` remove unnecessary empty lines that `gofumpt` does not remove for some reason - `superfluous-else` eliminate more superfluous `else` branches Rules are also sorted alphabetically and I cleaned up various parts of `.golangci.yml`. (cherry picked from commit 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2) Conflicts: .golangci.yml apply the linter recommendations to Forgejo code as well
This commit is contained in:
parent
31b608a1e9
commit
12b199c5e5
79 changed files with 130 additions and 193 deletions
|
@ -51,7 +51,6 @@ func PackagesNugetNuspecCheck(ctx context.Context, logger log.Logger, autofix bo
|
|||
logger.Info("Found %d versions for package %s", len(pvs), pkg.Name)
|
||||
|
||||
for _, pv := range pvs {
|
||||
|
||||
pfs, err := packages.GetFilesByVersionID(ctx, pv.ID)
|
||||
if err != nil {
|
||||
logger.Error("Failed to get files for package version %s %s: %v", pkg.Name, pv.Version, err)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue